-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix wasm_bindgen_test
macros
#2675
Conversation
wasm_bindgen_test_macros
wasm_bindgen_test
macros
hmm, looks like CI is still failing? |
Yeah, we'll have to wait for rustwasm/wasm-bindgen#3549 to be released. The failures are of the form
|
If you want a quick fix I can just pull |
Not necessary yet. I'll ask around first. |
I guess in the meantime, I'm willing to merge PRs while waiting for upstream changes... |
given that I got no response, I suppose we should just merge this/potentially with |
cool, okay --- @hlbarber, can i get you to add the import, then? |
@hawkw done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for working on this @hlbarber!
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
## Motivation Tests involving `wasm_bindgen_test` currently fail: https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576 ## Solution - [x] Use `extern crate wasm_bindgen_test` to side-step `no_implicit_prelude`. - [x] rustwasm/wasm-bindgen#3549 - [ ] Consume the release `wasm_bindgen_test` containing said change.
Motivation
Tests involving
wasm_bindgen_test
currently fail:https://github.com/tokio-rs/tracing/actions/runs/5756318807/job/15605512576
Solution
extern crate wasm_bindgen_test
to side stepno_implicit_prelude
.wasm_bindgen_test
for items exported from std prelude rustwasm/wasm-bindgen#3549wasm_bindgen_test
containing said change.